Metadata V16: Simplify Config and make it work across more chains by default #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
force-pushed
the
jsdw-metadata-v16-config
branch
3 times, most recently
from
f94c473 to
ca5e380
Compare
… Hash. Rename BlockHash trait to Hash
jsdw
force-pushed
the
jsdw-metadata-v16-config
branch
from
ca5e380 to
baaac56
Compare
jsdw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a small step toward using the associated type information present in V16 metadata (still unstable) to simplify the Subxt config. It:
Hashertype to beDyanmicHasher256, which will hash things usingBlakeTwo256orKeccak256(falling back to the former if no information available) depending on what the chain is configured with.Hashassociated type (since it's defined inHasheranyway), just to simplify Config a little.