This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Inject analytics script into rustdocs #14805
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A0-please_review
|
I believe I am not the right person to review the code. I am not familiar with the code base. |
ggwpez
reviewed
Aug 22, 2023
liamaharon
requested review from
kianenigma
and removed request for
jimmychu0807
ggwpez
approved these changes
Aug 22, 2023
| export -f process_file | ||
|
|
||
| # Locate all .html files under the documentation root and use xargs to process in parallel. | ||
| find "$path" -name '*.html' | xargs -I {} -P "$(nproc)" bash -c 'process_file "$@"' _ {} |
There was a problem hiding this comment.
Is nproc expected to be installed in this environment? Can you test it in a CI or where is this normally run?
|
Converting back to draft, it seems |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carinaluise asked for our simple analytics script to be embedded in the head of our rust doc html pages.
I've been testing it on my fork where it seems to be working https://github.com/liamaharon/substrate/tree/gh-pages