Conversation
Fiono11
force-pushed
the
olaf
branch
3 times, most recently
from
e07a49d to
6f24720
Compare
|
|
||
| # Format comments | ||
| comment_width = 100 | ||
| wrap_comments = true |
There was a problem hiding this comment.
Your git GUI has seemingly pulled recent changes from master into its own commit. I'd expect git handles this fine, likely disapears once rebased onto master, but it's odd behavior that indicates issues with the git GUI.
Did you make any other changes to this PR since 25 April?
There was a problem hiding this comment.
Yeah, I messed up...Pushed some changes directly to master instead of this branch and then pulled them.
| "precomputed-tables", | ||
| "legacy_compatibility", | ||
| "rand_core", | ||
| "serde", |
There was a problem hiding this comment.
How is rand_core being added as a feature? rand_core is not an ptional dependency
There was a problem hiding this comment.
I am not sure, does it have to be?
There was a problem hiding this comment.
rand_core is mandatory. why is this feature being added?
There was a problem hiding this comment.
Because without it it does not compile, I don't know why.
|
Replaced by #107. |
2 participants
This PR builds upon the previous PR #102 and implements the Olaf protocol. It is part of deliverable 1 of Web3 Foundation's grant w3f/Grants-Program#2250.