-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-linux compilation warnings. #248
Conversation
Hmmm... well, I'm not sure whether gating those to Linux is the way we want to go, due to a few reasons:
So I think what we could do:
|
Thanks for the suggestions! I've left a few |
Apologies for the borked merge. I run the CI on my fork: FluffyLabs#1 and it passes, so it should be ready for re-review. |
Thanks! |
I've started adding
#[cfg(target_os = "linux")]
but for some cases it starts a cascade of related code not being used, so I think it's safer to go with conditionally allowing dead code.Let me know what's your preference.