CI: check workspace dependency inheritance#11422
Merged
bkontur merged 49 commits intoJul 16, 2026
Merged
Conversation
Add cargo-workspace-inheritance-check to quick-checks CI workflow and fix all existing violations.
RomarQ
force-pushed
the
ci/check-workspace-inheritance
branch
from
March 18, 2026 17:44
d9bd519 to
8043da8
Compare
bkchr
approved these changes
Mar 18, 2026
bkchr
added
the
R0-no-crate-publish-required
Contributor
Author
|
@bkchr Should I add a PRdoc to fix the "Check semver" workflow? It should not change anything in terms of functionality, just aligns the dependency versioning in some crates. |
Member
|
No, should not be required. |
xermicus
approved these changes
Mar 20, 2026
0xOmarA
approved these changes
Mar 20, 2026
athei
approved these changes
Apr 21, 2026
acatangiu
enabled auto-merge
June 22, 2026 11:52
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jun 22, 2026
Contributor
Author
|
@acatangiu do you know what might have caused the PR to be removed from the merge queue? Or was it some CI flakiness? |
ptechrelease-forkwrite-polkadotsdk Bot
pushed a commit
to paritytech-release/polkadot-sdk
that referenced
this pull request
Jul 15, 2026
Blocked by paritytech/subxt#2236 Follow-up to paritytech#11422. Bumps the workspace `subxt`, `subxt-metadata`, and `subxt-signer` dependencies from 0.44 to 0.50. subxt 0.50 introduces a block-anchored client API and splits `subxt::Error` into per-operation sub-errors. Affected crates were updated to the new API; the JSON-RPC and CLI surfaces are unchanged.
…ace-inheritance # Conflicts: # Cargo.lock
PR paritytech#12096 bumped the workspace subxt/subxt-signer pin to 0.50 and moved the statement-store and zombienet-sdk crates onto workspace = true, so the ignore list (which existed to let them pin 0.50 while the workspace was on 0.44) no longer suppresses anything. Two entries also referenced the removed statement-latency-bench crate. The inheritance check stays green without it.
…into ci/check-workspace-inheritance
bkontur
approved these changes
Jul 16, 2026
bkontur
added a commit
to paritytech/web3-storage
that referenced
this pull request
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
Contributor
Author
|
@bkontur I think it failed because of CI flakiness |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
bkontur
enabled auto-merge
July 16, 2026 12:37
Merged
via the queue into
paritytech:master
with commit Jul 16, 2026
ec1052d
414 of 425 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-workspace-inheritance-checktochecks-quick.ymlCI workflow to enforce workspace dependency inheritanceworkspace = true, promote missing workspace deps)Recently, I found the need to have a tool for checking/fixing dependency inheritance in cargo workspaces. I think it can also be useful for polkadot-sdk.
For details about how it works, have a look at https://github.com/RomarQ/cargo-workspace-inheritance-check
Follow-up
Bumping the workspace pin to
0.50is a separate change. It requires porting the two crates still written against the0.44API:frame-benchmarking-cli— usesOfflineClient::new(…),subxt::client::RuntimeVersion, and.tx()directly on the offline client, all redesigned in0.50.pallet-revive-eth-rpc— usessubxt::Error::Metadata,subxt::error::MetadataError,subxt::ext::subxt_rpcs,subxt::backend::{legacy::rpc_methods, rpc},subxt::storage::Storage,subxt::events::StaticEvent,subxt::runtime_api, andsubxt::blocks— all gone or restructured in0.50.