wasm-builder: Only overwrite wasm files if they changed #10448
+112
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running two different `cargo` commands, they may both compile the same wasm files. When the second `cargo` command produces the same wasm files, we are now not gonna overwrite it. This has the advantage that we can run the first command again without it trying to recompile the project. Right now it would lead to the wasm files always getting recreated, which is wasting a lot of time :)
bkchr
added
the
T17-primitives
Member
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
lexnv
approved these changes
Nov 27, 2025
skunert
approved these changes
Nov 27, 2025
| let final_blob = if compressed_path.exists() { | ||
| Some(WasmBinary(compressed_path)) | ||
| } else if compact_path.exists() { | ||
| Some(WasmBinary(compressed_path)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Some(WasmBinary(compressed_path)) | |
| Some(WasmBinary(compact_path)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running two different
cargocommands, they may both compile the same wasm files. When the secondcargocommand produces the same wasm files, we are now not gonna overwrite it. This has the advantage that we can run the first command again without it trying to recompile the project. Right now it would lead to the wasm files always getting recreated, which is wasting a lot of time :)