-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Polkadot: Verify the workers at startup #10386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Polkadot: Verify the workers at startup #10386
Conversation
|
User @naijauser, please sign the CLA here. |
|
/cmd label T8-polkadot |
|
Hi @bkchr, please take a look. |
|
Command "label T8-polkadot" has failed ❌! See logs here |
bkchr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really fixing the issue right now.
|
Hi @bkchr, please take another look. The prepare and execute binaries require I'm not sure how to get the socket path. I looked through the codebase and found the function Should I use that function to get the socket path? Or is there another way to do it? You will notice that I commented out the let exit_status = Command::new(&prep_worker_path)
// .arg("--socket-path")
// .arg(socket_path.as_ref().as_os_str())
.arg("--worker-dir-path")
.arg(prep_worker_dir_path.as_os_str())
.arg("--check-all")
.status()
.unwrap(); |
Closes #8117
Description
Runs all security checks for the worker on polkadot node startup.
Checklist
Trequired)