Skip to content

Conversation

@naijauser
Copy link

@naijauser naijauser commented Nov 21, 2025

Closes #8117

Description

Runs all security checks for the worker on polkadot node startup.

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 21, 2025

User @naijauser, please sign the CLA here.

@naijauser
Copy link
Author

/cmd label T8-polkadot

@naijauser
Copy link
Author

Hi @bkchr, please take a look.

@github-actions
Copy link
Contributor

Command "label T8-polkadot" has failed ❌! See logs here

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really fixing the issue right now.

@naijauser
Copy link
Author

Hi @bkchr, please take another look.

The prepare and execute binaries require --socket-path and --worker-dir-path to be passed.

I'm not sure how to get the socket path. I looked through the codebase and found the function with_transient_socket_path. It is used somewhere to get the socket path, but it's an async function and may require a bit more refactoring of determine_workers_paths to use it.

Should I use that function to get the socket path? Or is there another way to do it?

You will notice that I commented out the --socket-path argument in the code

	let exit_status = Command::new(&prep_worker_path)
	// .arg("--socket-path")
        // .arg(socket_path.as_ref().as_os_str())
        .arg("--worker-dir-path")
        .arg(prep_worker_dir_path.as_os_str())
	.arg("--check-all")
	.status()
	.unwrap();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polkadot: Verify the workers at startup

2 participants