SSO message handling bindings for Mobile hosts - #433
Open
ERussel wants to merge 14 commits into
Open
Conversation
# Conflicts: # rust/crates/truapi-server/src/runtime/pairing_host/sso_channel.rs
# Conflicts: # android/truapi-host/src/main/kotlin/io/parity/truapi/TrUAPIHost.kt # ios/truapi-host/README.md # ios/truapi-host/Sources/TrUAPIHost/truapi_server.swift # ios/truapi-host/Sources/truapi_serverFFI/include/truapi_serverFFI.h
ERussel
force-pushed
the
feature/sso-integration
branch
from
August 18, 2026 04:59
7bc62c2 to
51e94bd
Compare
ERussel
marked this pull request as draft
August 18, 2026 05:14
ERussel
changed the title
ERussel
marked this pull request as ready for review
August 18, 2026 08:25
johnthecat
force-pushed
the
feature/sso-integration
branch
from
August 18, 2026 14:58
07424c1 to
251acb6
Compare
# Conflicts: # rust/crates/truapi-server/src/native.rs
valentinfernandez1
approved these changes
Aug 18, 2026
valentinfernandez1
left a comment
valentinfernandez1
left a comment
Collaborator
There was a problem hiding this comment.
Just 2 small nits. Everything else LGTM
Comment on lines
+91
to
+97
| Both platforms expose `TrUAPIHostRuntime`, the process-owned native runtime; wallet | ||
| hosts that manage their own statement-store SSO session can additionally call | ||
| `handleSsoRequest` (routes one decrypted remote message through the core, | ||
| returning a typed outcome: response bytes to post back, a disconnect marker, or | ||
| ignored) and `prepareDisconnectRequest` (builds the SCALE-encoded wire message | ||
| for a wallet-initiated disconnect). Response posting and session-record cleanup | ||
| remain on the wallet side. |
Collaborator
There was a problem hiding this comment.
I dont see TrUAPIHostRuntime on Android it only has TrUAPIHostCore, and these two methods weren't added to it, so Android can't call them at all.
| &self, | ||
| message: Vec<u8>, | ||
| ) -> Result<SsoRequestOutcome, HostRejection> { | ||
| let message = RemoteMessage::decode(&mut message.as_slice()).map_err(|err| { |
Collaborator
There was a problem hiding this comment.
consider using decode_remote_message(message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The PR introduces methods to process SSO request via Rust core runtime:
handleSsoRequestparses raw message, process it and returns an outcome. As there might be a need to perform additional cleanup session on the consumer level outcome includes a separate disconnect markerprepareDisconnectRequestallows to prepare a raw disconnect request when a user want's to close the sessionThe design assumes that mobile hosts handle SSO session via statement store natively and delegate only requests handling to the rust core. This is an accepted tradeoff now to bring unified TrUAPI handling on both platforms without huge refactoring.
NOTE: PR changes disconnect message id from static
truapi:sso:disconnectto random one to prevent collisions between messages. For example, peer might dedup by message id and second time disconnect message might be ignored if they ever received one from that host.Integration into iOS App: https://github.com/paritytech/polkadot-app-ios-v2/pull/1372