fix: match signing accounts by SS58 only (strict host) - #34
Open
decrypto21 wants to merge 1 commit into
Open
Conversation
mordamax
requested changes
Jun 26, 2026
mordamax
left a comment
mordamax
left a comment
Collaborator
There was a problem hiding this comment.
@decrypto21 please resolve conflicts
Also is there a way to test this addition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the raw-hex-pubkey fallback in getPairByAddress, so the test host matches signing accounts by SS58 address only - exactly like a real wallet. Rewires test-product.ts's trySignRaw to go through the real signer path (getLegacyAccountSigner(...).signBytes(...)) instead of hand-building the wire request.
Why
The hex fallback made the test host more lenient than production and silently masked paritytech/product-sdk#156: getLegacyAccountSigner was sending the signer as toHex(publicKey) instead of an SS58 address. With the fallback gone, legacy-account signRaw/signPayload fail here the same way they fail against a real wallet - so the suite catches this class of regression.
Gating
The legacy sign-raw integration test goes green only once this repo consumes the fixed wrapper (@novasamatech/host-api-wrapper ≥ 0.8.1, from triangle-js-sdks PR). Until then it correctly reproduces the failure. Don't merge ahead of that publish + dep bump.
Post-actions
Bumps version → 0.9.1, with CHANGELOG + forum-post entries per the repo's release checklist.