Conversation
justraman
requested review from
BigTava,
Cyr06130,
KarimJedda,
ba1uev,
leonardocustodio and
tallesborges
as code owners
August 12, 2026 11:46
Contributor
⚡ Performance Report
|
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: f27c614 |
Contributor
|
This is a Nova-side outage and not a dot.li test failure. Re-run Logs: https://github.com/paritytech/dotli-community/actions/runs/31593345203 |
Contributor
|
❌ E2E Product suite failed on Failed tests:
Logs: https://github.com/paritytech/dotli-community/actions/runs/32022016269 |
justraman
marked this pull request as draft
August 14, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #91
Once a verified desktop session logged in, the topbar slid away after 5s and the
only way back was hovering a 6px invisible strip at the top of the viewport.
Keyboard-only users lost home, settings, permissions and login for the rest of
the session, with no route back.
Two smaller problems in the same code path:
Changes
Auto-hide moves out of
main.tsintopackages/ui/src/topbar-autohide.ts, whereit can be unit tested.
main.tskeeps only the auth/shield wiring(
armTopbarAutoHideon login,pinTopbarVisibleon logout).Keyboard access:
focusinreveals the bar when focus lands in#topbaror anysurface it owns (user, settings, permissions popovers, pairing modal). The
hidden bar keeps its tab stops on purpose, so tabbing into it is the reveal.
Alt+Shift+Ttoggles the bar. Revealing moves focus to the first control,hiding hands focus back to the app frame so it never parks off-screen.
Advertised via
aria-keyshortcutswhile armed. Matched onevent.code(with a
keyfallback) because macOS turns Option+Shift+T into a dead key.pulling the controls away mid-interaction.
#topbargainsrole="banner"so it is reachable by landmark navigation.