Pseudo batch-less operations #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkuhn
reviewed
Mar 10, 2023
include/core/jbatch.h
Outdated
| * Default semantic settings will be used for execution. | ||
| * | ||
| */ | ||
| #define J_SINGLE_OP NULL |
Member
There was a problem hiding this comment.
I think the name should include batch, maybe J_BATCH_SINGLE?
lib/core/jbatch.c
Outdated
Comment on lines
276
to
279
| if (batch == J_SINGLE_OP) | ||
| { | ||
| return j_semantics_new(J_SEMANTICS_TEMPLATE_DEFAULT); | ||
| } |
Member
There was a problem hiding this comment.
We could also allocate a semantics singleton so callers do not have to free the semantics. I'm not sure whether it's worth the effort, though.
| /** | ||
| * Returns a batch's semantics. | ||
| * | ||
| * The returned object must be freed using j_semantic_unref. |
Member
There was a problem hiding this comment.
Does this affect any existing code? It could lead to memory leaks.
lib/item/jitem.c
Outdated
Comment on lines
249
to
250
| ret &= j_kv_delete(item->kv, batch); | ||
| ret &= j_distributed_object_delete(item->object, batch); |
Member
There was a problem hiding this comment.
Is this correct? & is not necessarily the same as &&.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to pass
J_SINGLE_OPto operations instead of a batch. The operation will then be directly executed using default semantics.