Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix spelling and grammar mistakes #50

Merged
merged 1 commit into from
Dec 8, 2023
Merged

docs(readme): fix spelling and grammar mistakes #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# parca-demo

This parca-demo repository contains a minikube virtual machine that runs Kubernetes with Parca and the agent.
You can choose to deploy demo applications in various languages to that cluster to checkout each languages' support.
You can choose to deploy demo applications in various languages to that cluster to check out each language's support.

## Lanaguages
## Languages

Compiled languages such as C/C++, Rust and Go are currently supported. (There are some requirements though, binaries should be compiled with [frame pointers](https://en.wikipedia.org/wiki/Call_stack#Stack_and_frame_pointers) and [debug symbols](https://en.wikipedia.org/wiki/Debug_symbol). There are planned improvements for loosening these requirements.`**`)

Expand Down Expand Up @@ -82,7 +82,7 @@ Type to check deployments (again to uncheck, ENTER when done):

Note: This will take some time to pull down base images and build each language's demo.

At the end you should have a demo for each language in the cluster.
At the end, you should have a demo for each language in the cluster.

Tip: You can also deploy the demos in one line: ```./deploy-apps.sh cpp java rust```

Expand All @@ -91,7 +91,7 @@ Tip: You can also deploy the demos in one line: ```./deploy-apps.sh cpp java rus
Access Parca by port-forwarding to it by running: `kubectl port-forward -n parca svc/parca 7070`.
Open http://localhost:7070/

Once you selected the profile type you want to see (currently only CPU Samples) you can query for languages by using these selectors:
Once you have selected the profile type you want to see (currently only CPU Samples), you can query for languages by using these selectors:
```

namespace="parca", pod=~"go-.*"
Expand Down