Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(julia): custom build without Frame Pointer Omission #37

Closed
wants to merge 1 commit into from

Conversation

maxbrunet
Copy link
Member

@maxbrunet maxbrunet commented Feb 12, 2023

Frame Point Omission is enabled by default on Linux and not configurable: JuliaLang/julia#40655

This re-uses the Nix package by applying a patch to it, and avoids messing with the Julia's many build dependencies directly.

Opened for the record, hardly supportable by us, build is long (~1h on my machine), we would probably need to publish the built image, better wait for an improvement from the Julia project.

image

ref: #8

@maxbrunet maxbrunet force-pushed the fix/julia/jl-disable-fpo branch from 72d589a to 05de8de Compare February 12, 2023 20:35
@maxbrunet maxbrunet requested a review from a team February 13, 2023 20:40
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ 💚 💙 💛 💜

@maxbrunet maxbrunet closed this Mar 6, 2023
@kakkoyun
Copy link
Member

kakkoyun commented Mar 7, 2023

I think we should have a Julia example in this repo.

@maxbrunet
Copy link
Member Author

We have one: main/julia. I'll update it with latest 1.9 RC, once it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants