Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that upload is not going to be empty #20

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Ensure that upload is not going to be empty #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/parca-debuginfo/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ func run(kongCtx *kong.Context, flags flags) error {

buf.SeekStart()
upload.size = int64(buf.Len())

if upload.size == 0 {
return fmt.Errorf("extracted debug information from %q is empty, but must not be empty", upload.path)
}
}
} else {
for _, path := range flags.Upload.Paths {
Expand Down Expand Up @@ -192,6 +196,10 @@ func run(kongCtx *kong.Context, flags flags) error {
return fmt.Errorf("stat file: %w", err)
}

if fi.Size() == 0 {
return fmt.Errorf("file %q is empty, but must not be empty", path)
}

uploads = append(uploads, &uploadInfo{
buildID: buildID,
path: path,
Expand Down
Loading