DWARF: Add logging for unexpected CFA opcodes #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
reviewed
Feb 6, 2024
Sylfrena
force-pushed
the
dwarf-panic-replace
branch
from
bddc587 to
ecf0036
Compare
brancz
reviewed
Feb 7, 2024
Sylfrena
force-pushed
the
dwarf-panic-replace
branch
from
38426ed to
e0fde79
Compare
brancz
reviewed
Feb 8, 2024
Sylfrena
force-pushed
the
dwarf-panic-replace
branch
2 times, most recently
from
16be55c to
a0630ae
Compare
brancz
reviewed
Feb 9, 2024
Signed-off-by: Sumera Priyadarsini <[email protected]>
Signed-off-by: Sumera Priyadarsini <[email protected]>
Signed-off-by: Sumera Priyadarsini <[email protected]>
Sylfrena
force-pushed
the
dwarf-panic-replace
branch
from
a0630ae to
156c451
Compare
brancz
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
An end-user found an unexpected DWARF opcode in #2459 causing the agent to panic.
As there was no logging, the binary which has this opcode could not be determined
Test Plan
CI tests