Don't set custom labels ID if we failed to save the hash (#2915)

Co-authored-by: Tommy Reilly <[email protected]>
parca-dev · Jul 9, 2024 · 2815ded · 2815ded
1 parent f836934
commit 2815ded
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/bpf/unwinders/native.bpf.c b/bpf/unwinders/native.bpf.c
@@ -769,7 +769,8 @@ static __always_inline void add_stack(struct bpf_perf_event_data *ctx, u64 pid_t
                         int err = bpf_map_update_elem(&custom_labels, &hash, lbls, BPF_ANY);
                         if (err)
                             LOG("[error] failed to update custom labels with %d", err);
-                        stack_key->custom_labels_id = hash;
+                        else
+                            stack_key->custom_labels_id = hash;
                     } else
                         LOG("[error] failed to compute hash for custom labels");
                 } else {