Fix kernel module parsing when flags are present #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you! lgtm |
|
Do you mind opening the same patch against upstream? |
I was about to but I just realised that it has been fixed and I just missed it. The commit it was fixed in was open-telemetry@fc0dcae but it is called "handle nvidia kernel modules" rather than the one before it called "Fix parsing Kernel Module lines where refcount is "-"". This isn't just for NVIDIA kernel modules but it's the same fix. Sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue mentioned at parca-dev/parca-agent#3018 and #29
If a line
/proc/moduleshas flags they are now ignored instead of included as part of the address. This is done by splitting the line by 7 at most instead of 6 at most.