Fix varinfo parsing for luajit local var name lookup #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were decrementing the slot when PC was out of bounds which is wrong because LuaJIT reuses stack slots for locals in different scopes. This caused us to hit on local var lookup instead of failing and falling through to looking at bytecode names. Add a test case lifted from luajit that shows slots being reused for different variables and remove old unhelpful test case.
gnurizen
force-pushed
the
varinfo-fix
branch
from
5f2fbf7 to
220a5ab
Compare
brancz
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were decrementing the slot when PC was out of bounds which is wrong
because LuaJIT reuses stack slots for locals in different scopes. This
caused us to hit on local var lookup instead of failing and falling
through to looking at bytecode names.
Add a test case lifted from luajit that shows slots being reused for
different variables and remove old unhelpful test case.