Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wgpu to 0.17 #378

Merged
merged 2 commits into from
Oct 30, 2023
Merged

update wgpu to 0.17 #378

merged 2 commits into from
Oct 30, 2023

Conversation

barzamin
Copy link
Contributor

the required changes are trivial. wgpu::util::initialize_adapter_from_env's signature changed; the backend_bits parameter was removed. allowed backends are now fully constrained by the instance's enabled set (see the changelog).

required changes are entirely trivial:
wgpu::util::initialize_adapter_from_env's signature changed;
the backend_bits parameter is removed, and now solely specified by
the instance's enabled backends (see [the changelog](https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#initialize_adapter_from_env-argument-changes)).
@parasyte
Copy link
Owner

The new version of egui is requiring Rust 1.70. We can increment the MSRV for this. The last time this happened was in #320.

It's a bit challenging because the MSRV in the policy will need to be 1.70, but the crate itself can technically be on an older version (perhaps remaining on 1.64?) so that it can be used with older compilers when egui is not used.

@barzamin
Copy link
Contributor Author

I can bump MSRV.md and the CI config if you want, unless you'd prefer to touch the policy stuff yourself (I think the PR is editable by maintainers).

@parasyte
Copy link
Owner

You are welcome to give it a shot if you'd like to see this land sooner than I could get around to it! I have some free time on Sunday which might be the soonest I could manage.

Copy link
Owner

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you.

@parasyte parasyte merged commit 763a7a9 into parasyte:main Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants