-
Notifications
You must be signed in to change notification settings - Fork 81
Set installed toolchain as default and bump MSRV to 1.77 #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm... okay, fixing this uncovered another issue: the bindings are using Do you think we should upgrade our MSRV or rather find a way to generate sources without Apparently it is possible to set Rust target when generating bindings: rust-lang/rust-bindgen#2960 (comment) |
I do not have much experience or overview what all implications of bumping MSRV are, but given that this was here for quite some time and only now somebody noticed, I would say lets bump it. Sounds like there is really not a huge interest in old rust versions in there. From technical point of view, do we know what is the alternative generated with bindgen set with |
The docs for the action indicate that unless specified the toolchain will not be used by default. Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
925468e
to
d73f78d
Compare
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
d73f78d
to
8b1a132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no concerns here
Thanks 👋 . Let's wait for @hug-dev since he touched these parts previously and may have valuable input. |
Checking at Rust packages in Ubuntu, seems like 1.77 is available on old distributions too so I think we can go with it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I am thinking that we could as well write what the MSRV is somewhere in a README! Unneeded as the rust-version
field conveys exactly that information
The docs for the action indicate that unless specified the toolchain will not be used by default.