Update crates #670
Closed
Update crates #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fuzz test failure has been fixed in rust and should pass with the next nightly. |
gowthamsk-arm
force-pushed
the
update_crates
branch
from
54805a0 to
beb51b4
Compare
gowthamsk-arm
force-pushed
the
update_crates
branch
from
e0046e9 to
af045b7
Compare
anta5010
reviewed
Mar 20, 2023
| # Download and install TSS 2.0 | ||
| RUN git clone https://github.com/tpm2-software/tpm2-tss.git --branch 2.3.3 | ||
| # Download and install TSS 3.2.0 | ||
| RUN git clone https://github.com/tpm2-software/tpm2-tss.git --branch 3.2.0 |
There was a problem hiding this comment.
We also compile parsec 1.0.0 to generate keys for the sqlite and ondisk KIM. 1.0.0 uses an older version of tss-esapi crate aborts with an error if 4.0.1 is used.
There was a problem hiding this comment.
can we build two versions of tpm2-tss - for parsec 1.0.0 and the current version of parsec? While using TSS v3 in CI we might miss issues similar to #663
There was a problem hiding this comment.
Will try adding both
gowthamsk-arm
force-pushed
the
update_crates
branch
6 times, most recently
from
41e7610 to
dcdedfd
Compare
The cross compilation of the latest psa-crypto sys crate fails for aarch64 target on a ubuntu 18.04 machine. This is due to the 0.63.0 version of bindgen in psa-crypto-sys. The latest bindgen crate has a check which compares size_t, ssize_t with target pointer and aborts if they are unequal when size_t_is_usize flag is set. In ubuntu 18.04 these are read as 4 and 8 bytes respectively which is wrong. This is an issue with the c library mismatchs of target toolchains in 18.04. Hence we are updating the docker test image to 22.04. Also, 18.04 is reaching end of life in April 2023. This commit involves the following changes: - Use ubuntu 22.04 as base image - Dependency packages missing in 22.04 have been added - Tpm library versions have been bumped as 22.04 has openssl > 3.0 - Older version libts used to generate keys has been removed as the missing dependencies for it causes compilation issues. Instead we use parsec 1.0.0 which uses a libts version which is compatible with 22.04 for generating keys for both SQLite and OnDisk KIM. Signed-off-by: Gowtham Suresh Kumar <[email protected]> # OnDisk KIM.
As part of the release, we need to use all the latest parsec crates and bump versions of other crates to use a single version. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The lock file changes in this commit are due to the cargo update command issued to bump the crate versions. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
update_crates
branch
from
dcdedfd to
b17502f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR has the following changes:
Signed-off-by: Gowtham Suresh Kumar [email protected]