Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring and improvements #396

Merged
merged 32 commits into from
Apr 2, 2016
Merged

[WIP] Refactoring and improvements #396

merged 32 commits into from
Apr 2, 2016

Conversation

iBelieve
Copy link
Member

  • Initial work on a QPM package
  • Add a C++ plugin
  • Implement Device and Units in C++
  • Units uses the new HiDPI code from Qt 5.6, defaulting to new per-screen calculations on Qt 5.5 and earlier.
  • Units.dp/Units.gu become properties instead of functions because C++ methods won't trigger binding updates like properties do
  • Units.dp/Units.gu are exposed as dp/gu in all the top-level Window via UnitsHelper
  • Icons/fonts are no longer all included. Icons are only included as necessary via the icons.yml file and icons.py script

TODO:

  • Implement optional fonts
  • Verify that the QPM package will work
  • Fix failing unit tests

Fixes #384
Fixes #382
Fixes #380
Fixes #363
Fixes #359
Fixes #358
Fixes #394
Fixes #381

@marco-piccolino
Copy link
Contributor

this is huge! looking forward to the merge

@IdrissDimson
Copy link

This seems like a really exciting update!

@nimaim
Copy link

nimaim commented Mar 24, 2016

Agree, this seems like one hell of an update! Thanks @ibeliever !

This was referenced Mar 31, 2016
@iBelieve iBelieve merged commit 644e558 into develop Apr 2, 2016
@alexkreidler
Copy link

Yay! It is merged!

@IdrissDimson
Copy link

\o/ Now to work on 0.2!

@iBelieve iBelieve deleted the feature/refactoring branch April 2, 2016 20:57
@luntik2012
Copy link

Thank you!
I don't know, where could I ask this, but what you guys think about QtLabControls? Will you merge with it? Did you seen it? Will you assist Qt-team with this somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants