This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Feature wait for sentinel #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stumpylog
force-pushed
the
feature-wait-for-sentinel
branch
from
61cf01d
to
c901254
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Architecture
Then sentinel guard loop constantly looped, checking if the processes were still alive or needed to be recycled, before sleeping a short period and starting the loop over again.
New Architecture
Every Python Process object has a
sentinelfield associated with it, whichmultiprocessing.connection.waitcan block on. This call returns when the sentinel is "ready", which for a process means the process has ended (either through death or finishing work to be recycled).Using this, the cluster sentinel can wait for any of the objects to end and deal with the ending on an as needed basis, rather than polling for changes in process status.
Considerations
Needs #2 merged first, then the guard loop can be cleaned up further, removing the sleep portion entirely.