Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade serde and related crates #21437

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Sep 19, 2024

Upgrade serde and related crates:

     Locking 6 packages to latest compatible versions
    Updating serde v1.0.197 -> v1.0.210
    Updating serde_derive v1.0.197 -> v1.0.210
    Updating serde_json v1.0.116 -> v1.0.128
    Updating serde_test v1.0.176 -> v1.0.177
    Updating serde_yaml v0.9.32 -> v0.9.34+deprecated
    Updating unsafe-libyaml v0.2.10 -> v0.2.11

Note: serde_yaml is no longer maintained (as per its crates.io page). This PR does not try to move away from it.

@tdyas tdyas added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Sep 19, 2024
@tdyas tdyas requested review from benjyw and huonw September 20, 2024 14:00
@benjyw
Copy link
Contributor

benjyw commented Sep 25, 2024

Shouldn't there be a corresponding Cargo.toml change in this PR?

@tdyas
Copy link
Contributor Author

tdyas commented Sep 25, 2024

Shouldn't there be a corresponding Cargo.toml change in this PR?

cargo update does not do that. The newer version in the Cargo.lock is still compatible with the version pin in the Cargo.toml so no real need to bump the version requirement in the Cargo.toml.

@tdyas tdyas merged commit 69ce39e into pantsbuild:main Sep 25, 2024
25 checks passed
@tdyas tdyas deleted the upgrade_serde_crates branch September 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants