Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge yet] Remove support for coursier v2.1.6 #20179

Closed
wants to merge 1 commit into from
Closed

[Do not merge yet] Remove support for coursier v2.1.6 #20179

wants to merge 1 commit into from

Conversation

gauthamnair
Copy link
Contributor

@gauthamnair gauthamnair commented Nov 14, 2023 •
edited
Loading

Blunt fix for
#20174

Removes all 2.1.6 known versions

@gauthamnair gauthamnair mentioned this pull request Nov 14, 2023
Closed
@benjyw benjyw added this to the 2.18.x milestone Nov 14, 2023
@benjyw benjyw added needs-cherrypick category:bugfix Bug fixes for released features labels Nov 14, 2023
benjyw
benjyw approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@gauthamnair
Copy link
Contributor Author

@benjyw @huonw Adding some discussion in the issue. It turns out that coursier M1 is not broken for 2.1.6. Rather, the jdk we are asking it to fetch in the example-jvm repo happens to not be available for M1, but there are jdks that are available. Will post more there.

@gauthamnair gauthamnair changed the title Remove support for coursier v2.1.6 [Do not merge yet] Remove support for coursier v2.1.6 Nov 14, 2023
@gauthamnair
Copy link
Contributor Author

We may be able to close this as soon as #20184 is sorted out. pantsbuild/example-jvm#29 fixed the original reported issue.

@gauthamnair
Copy link
Contributor Author

This does not need to be done, nothing wrong with coursier 2.1.6 on M1 Mac, we were just asking for unavailable jvms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.18.x
Development

Successfully merging this pull request may close these issues.
3 participants
@gauthamnair @benjyw @huonw