BUG: empty slice assignment raises if datetime column is present #50942 #62934
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 31, 2025
pandas/tests/indexing/test_loc.py
Outdated
Comment on lines
264
to
267
| DataFrame({"A": [datetime(2025, 10, 30)]}), | ||
| DataFrame({"A": [Timestamp(2025, 10, 30)] * 2}), | ||
| DataFrame({"A": [Timedelta(1)]}), | ||
| DataFrame({"A": [Timedelta(1), Timedelta(2)]}), |
Member
There was a problem hiding this comment.
Can you construct the DataFrame in the body of the test?
mroeschke
requested changes
Oct 31, 2025
mroeschke
added
the
Testing
mroeschke
reviewed
Nov 4, 2025
pandas/tests/indexing/test_loc.py
Outdated
Comment on lines
274
to
280
| try: | ||
| df = DataFrame(data=data, columns=["A"]) | ||
| res = df.loc[mask] | ||
| res = df | ||
| tm.assert_frame_equal(res, df) | ||
| except Exception: | ||
| pytest.fail("loc empty slice assignment raised Exception unexpectedly!") |
Member
There was a problem hiding this comment.
- You can remove the
try/except - In the original issue, it's testing a setitem, so this would need to be
expected = df.copy()
df.loc[mask] = df
tm.assert_frame_equal(df, expected) 
mroeschke
approved these changes
Nov 7, 2025
Member
|
Thanks @litang99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.