BUG: Correctly handle fill_value in Series._flex_method for ExtensionArrays #62815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 22, 2025 18:25
…d weakrefs when clearing referenced_blocks; add regression tests
…H#62787 CoW replace np.nan bug
…FINAL_REPORT.md line endings
… stale indices and dead weakrefs (GH#62787)
…avoid breaking external references (GH#62787)
- Tests verify iloc preserves dictionaries in object dtype Series - Covers edge cases: nested dicts, multiple assignments, consistency with direct assignment - Includes regression test for original bug scenario - All tests pass pre-commit checks
- Remove unused numpy and pandas._testing imports - Standardize string quotes to double quotes throughout - Add trailing commas and fix whitespace - Pre-commit formatting improvements
|
Per #62808 (comment), I will now be blocking your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where flexible arithmetic methods (e.g.,
add,sub) on apandas.Seriesbacked by anExtensionArraydid not correctly handle thefill_valueparameter. Previously, the_flex_methodfailed to apply thefill_valueto missing data before performing the operation, leading to unexpectedNotImplementedErroror incorrect results. This behavior was inconsistent with Series backed by NumPy arrays.The fix adjusts the logic in
Series._flex_methodto properly substitute missing values with the providedfill_valueprior to executing the arithmetic operation on theExtensionArray. This ensures consistent and predictable behavior across different Series types.