TST: Add test for Arrow decimal groupby variance #62754
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nour-taqatqa
commented
Oct 19, 2025
nour-taqatqa
commented
- closes test case for BUG: groupby.var() does not return arrow types with arrow backed series as input. #54627
mroeschke
requested changes
Oct 20, 2025
pandas/core/groupby/groupby.py
Outdated
| data = self._get_data_to_aggregate(numeric_only=numeric_only, name=how) | ||
|
|
||
| def array_func(values: ArrayLike) -> ArrayLike: | ||
| def array_func(values: ArrayLike) -> ArrayLike: |
There was a problem hiding this comment.
Can you undo the changes in this file?
| #testing groupby.var() when called with pyarrow datatype | ||
|
|
||
| @pytest.mark.parametrize("with_na", [False, True]) | ||
| def test_groupby_var_arrow_decimal(with_na): |
There was a problem hiding this comment.
- Can you put this test in
pandas/tests/extension/test_arrow.py? - Can you just use the example in BUG: groupby.var() does not return arrow types with arrow backed series as input. #54627 (comment)? You should be able to use
tm.assert_frame_equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.