BUG: Fix DatetimeIndex timezone preservation when joining indexes with same timezone but different units #61234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h same timezone but different units
|
Hi @rhshadrach, could you please check this one out? |
rhshadrach
requested changes
Apr 16, 2025
There was a problem hiding this comment.
@mroeschke - this change will make it so the unit comes out to be the minimum between the two time inputs. Does that look like the correct behavior to you?
Comment on lines
+215
to
+219
| # Test union preserves timezone when units differ | ||
| result = idx1.union(idx2) | ||
| expected = date_range("2000-01-01", periods=3, tz=tz).as_unit("ns") | ||
| tm.assert_index_equal(result, expected) | ||
| assert result.tz == idx1.tz # Original timezone is preserved |
There was a problem hiding this comment.
Can you either break these up into separate tests or parametrize them.
|
I agree with @rhshadrach's comment on splitting/parametrizing the test, otherwise this LGTM |
Address review comments on PR pandas-dev#60080 by splitting the comprehensive test into separate focused tests for each set operation (union, intersection, symmetric_difference).
rhshadrach
requested changes
Apr 25, 2025
| result = idx1.union(idx2) | ||
| expected = date_range("2000-01-01", periods=3, tz=tz).as_unit("ns") | ||
| tm.assert_index_equal(result, expected) | ||
| assert result.tz == idx1.tz # Original timezone is preserved |
There was a problem hiding this comment.
Can you remove assert result.tz == idx1.tz throughout; this is already checked by assert_index_equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.