ENH: Make print_thing respect display.precision for Real numbers #60613
Conversation
pandas/io/formats/printing.py
Outdated
| escape_chars = list(escape_chars.keys()) | ||
| else: | ||
| escape_chars = escape_chars or () | ||
|
|
||
| result = str(thing) | ||
| # Real instance kontrolü ve precision uygulaması | ||
| if isinstance(thing, Real) and not isinstance(thing, int): |
There was a problem hiding this comment.
Can you use is_float from padnas.core.dtypes.inference
pandas/io/formats/printing.py
Outdated
| escape_chars = list(escape_chars.keys()) | ||
| else: | ||
| escape_chars = escape_chars or () | ||
|
|
||
| result = str(thing) | ||
| # Real instance kontrolü ve precision uygulaması |
There was a problem hiding this comment.
This comment repeats the code verbatim and can be removed. Also, can you make any comments in English.
| import pytest | ||
|
|
||
| from pandas._config.config import option_context # option_context |
| @@ -155,6 +158,13 @@ def test_east_asian_len(self): | |||
| assert adj.len("パンダpanda") == 11 | |||
| assert adj.len("ﾊﾟﾝﾀﾞpanda") == 10 | |||
|
|
|||
| def test_pprint_thing_real_precision(self): | |||
There was a problem hiding this comment.
Can you move to TestPPrintThing above
| @@ -155,6 +158,13 @@ def test_east_asian_len(self): | |||
| assert adj.len("パンダpanda") == 11 | |||
| assert adj.len("ﾊﾟﾝﾀﾞpanda") == 10 | |||
|
|
|||
| def test_pprint_thing_real_precision(self): | |||
| with option_context('display.precision', 3): | |||
| assert pprint_thing(3.14159265359) == "3.142" | |||
There was a problem hiding this comment.
Use printing.pprint_thing instead, as the other tests here do
rhshadrach
added
Output-Formatting
- Replace isinstance(thing, Real) with is_float - Remove Turkish comments and unnecessary inline comments - Move test_pprint_thing_real_precision to TestPPrintThing class - Use consistent printing.pprint_thing import style
- Remove Real numbers reference from docstring - Remove Turkish comments - Fix import structure in tests
|
@aydinomer00 - looks like the CI is failing. Let me know if you'd like assistance. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing as stale. @aydinomer00 - if you'd like to continue, merge main and address the comments above, and we'd be more than happy to reopen! |
closes ENH: How about let pprint_thing print Real instance according to display.precision #60503
Tests added and passed:
All code checks passed
Added type annotations for clarity in modified functions
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file:
- Enhanced print_thing to respect display.precision setting for Real numbers
This PR modifies the print_thing function to respect display.precision settings when formatting Real numbers. For example: