Skip to content

TST: Add test for numpy.maximum with Timestamp and Series of datetime64 #59338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

TST: Add test for numpy.maximum with Timestamp and Series of datetime64 #59338

merged 1 commit into from
Jul 29, 2024

Conversation

tirthrajj
Copy link
Contributor

@tirthrajj tirthrajj commented Jul 28, 2024 •
edited
Loading

Added new test to make sure numpy.maximum on Timestamp and Series of datetime64 works correctly and does not fail with TypeError.

@tirthrajj
Copy link
Contributor Author

tirthrajj commented Jul 28, 2024 •
edited
Loading

CI failures here may get fixed after #59329

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jul 29, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jul 29, 2024
@mroeschke mroeschke merged commit 7acec4f into pandas-dev:main Jul 29, 2024
44 of 50 checks passed
@mroeschke
Copy link
Member

Thanks @Tirthraj93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: numpy.maximum(pandas.Timestamp(...), pandas.Series(..., dtype='datetime64')) fails with TypeError
2 participants
@tirthrajj @mroeschke