BUG: fix+test DTA/TDA/PA add/sub Index #27726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Aug 4, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
style comment in the test, otherwise lgtm (can do in a followup if you want), lmk.
| def test_dta_add_sub_index(self, tz_naive_fixture): | ||
| # Check that DatetimeArray defers to Index classes | ||
| dti = date_range("20130101", periods=3, tz=tz_naive_fixture) | ||
| dta = dti._data |
| def test_parr_add_sub_index(self): | ||
| # Check that PeriodArray defers to Index on arithmetic ops | ||
| pi = pd.period_range("2000-12-31", periods=3) | ||
| parr = pi._data |
| def test_tda_add_sub_index(self): | ||
| # Check that TimedeltaArray defers to Index on arithmetic ops | ||
| tdi = TimedeltaIndex(["1 days", pd.NaT, "2 days"]) | ||
| tda = tdi._data |
jreback
added
Compat
Member
Author
|
_data -> array edits made |
Contributor
|
lgtm ping on green. |
Member
Author
|
ping |
Contributor
|
thanks! |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLooking forward to doing a couple of test-cleanup passes.