Skip to content

fix(DataFrame): #799 to_dict #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Jul 19, 2025

@cmp0xff cmp0xff force-pushed the hotfix/yw/799-to-dict branch from 94f0d80 to d041ff2 Compare July 19, 2025 20:05
@cmp0xff cmp0xff force-pushed the hotfix/yw/799-to-dict branch from 1b5bb8c to 7da086e Compare July 19, 2025 20:24
@cmp0xff cmp0xff marked this pull request as ready for review July 19, 2025 20:33
@cmp0xff cmp0xff marked this pull request as draft July 19, 2025 23:02
@cmp0xff cmp0xff force-pushed the hotfix/yw/799-to-dict branch 3 times, most recently from 8bf75d2 to 4f1fb49 Compare July 20, 2025 13:24
@cmp0xff cmp0xff force-pushed the hotfix/yw/799-to-dict branch from 4f1fb49 to afb5729 Compare July 20, 2025 15:18
@cmp0xff cmp0xff marked this pull request as ready for review July 20, 2025 15:23
@cmp0xff cmp0xff requested a review from Dr-Irv July 28, 2025 11:52
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff

@cmp0xff
Copy link
Contributor Author

cmp0xff commented Jul 31, 2025

Hi @Dr-Irv, thank you for the approval. However, regarding #1283 (comment), do we have some guideline here?

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jul 31, 2025

Hi @Dr-Irv, thank you for the approval. However, regarding #1283 (comment), do we have some guideline here?

Not really. My attitude is that if we construct a set of tests that are allowing us to test proper usage, and reject improper usage, I'm fine with using Never this way. I should note that if a declaration returning Never is matched, then the type checkers aren't going to say "that's invalid", but they may or may not say that code that follows the improper usage won't execute.

Maybe one day the typing gods will agree on an approach to do "negative" typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.to_dict(orient="index") should return a nested dictionary
4 participants