feat: add position manager helper -- only check balance after#90
Closed
ChefMist wants to merge 2 commits into
Closed
feat: add position manager helper -- only check balance after#90ChefMist wants to merge 2 commits into
ChefMist wants to merge 2 commits into
Conversation
chefburger
approved these changes
Jul 28, 2025
ChefMist
changed the title
Contributor
Author
|
closing per discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible enhancement on #89
where we expect caller will check the current balance beforehand (can be off-chain) -- so we saves gas by only checking user's balance after modify liquidities
though the gas saving seems small (eg. if check 1 binId -- its 3000+ gas)