refactor: islamic-finance plugin v3.0.0 — fix router, remove bloat#10
Merged
Conversation
P0: Fix router SKILL.md — inline routing rules, remove broken $(cat ...) shell expansion P1: Remove exercises/ (14 files — all duplicated in Ch 20 lessons) P1: Remove workflow-recipes/ (4 files — content absorbed into Ch 20 L18) P2: Move root references/ under router skill (agentskills.io spec) P2: Add .gitignore and CLAUDE.md (parity with banking plugin) P3: Update README.md and plugin.json Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P0 Critical Fix: Router SKILL.md had a broken
$(cat "/Users/mjs/...")shell expansion — the routing rules never loaded for any user who installed the plugin. Fixed by inlining the full 5-step routing protocol.P1 Cleanup (matching banking plugin pattern):
exercises/(14 files) — all duplicated in Ch 20 lessons L04-L18workflow-recipes/(4 files) — content absorbed into Ch 20 L18 as/scheduleinstructionsP2 Structural:
references/underskills/islamic-finance-router/references/(agentskills.io spec).gitignoreandCLAUDE.md(parity with banking plugin)What Stays
Companion Book Change
Ch 20 L18 expanded with
/scheduleinstructions: pushed tofix/ch21-banking-scheduled-tasksbranch (PR #856)🤖 Generated with Claude Code