replace pytest-xprocess #2963
Merged
replace pytest-xprocess #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: Sudhanshu Pandey <[email protected]>
|
@sp6370 I finally found time to finish investigating this, and got it all working. Thanks for your work during the sprint, I credited you with co-authored-by in the first commit based on all that. |
|
@davidism Thanks a lot for wrapping this. I was able to learn a lot through this. Looking forward to seeing you at the next PyCon. 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly manage the dev server subprocess instead of using pytest-xprocess. While this adds some code, overall it's less complex than how pytest-xprocess works, and we didn't seem to need those complexities. I found it's easier to step through and access the different parts during a test if needed. It's also easier to start the server and use the client outside of a pytest session, if we need to debug something really tricky and don't want to deal with pytest. Calling
proc.wait()afterproc.terminate()ensures we don't seen any resource warnings, so those ignores can be removed. The tests seem to run about 1-2 seconds faster on my machine.closes #2906