Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python 3.13 wheels (non free-threaded) #461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link

Python 3.13 RC1 was released recently1:

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.13 compatibilities during this phase, and where necessary publish Python 3.13 wheels on PyPI to be ready for the final release of 3.13.0. Any binary wheels built against Python 3.13.0rc1 will work with future versions of Python 3.13. As always, report any issues to the Python bug tracker .

It'd be really nice to have wheels to start testing applications that use MarkupSafe before the eventual final release.

Thanks!

PS: This PR is only for GIL-enabled 3.13 wheels and not free-threaded ones2, which will certainly involve a higher level of effort.

Related: #460

Footnotes

  1. https://discuss.python.org/t/python-3-13-0-release-candidate-1-released/59703

  2. https://docs.python.org/3.13/whatsnew/3.13.html#free-threaded-cpython

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 18, 2024 17:39
@edgarrmondragon edgarrmondragon changed the title Build Python 3.13 wheels (non free-threaded) only for testing Build Python 3.13 wheels (non free-threaded) Aug 18, 2024
@davidism
Copy link
Member

davidism commented Aug 18, 2024

Thanks. However, I don't plan to merge this without free threading handled as well, as that would just make more work for me later on to try to figure out how to upload a new build for the same MarkupSafe and Python version, something my publish automation is not set up for.

From the linked documentation in #460, it doesn't seem like much additional work, but as I said there I won't have time to work on it soon. So if you can get it in here, that's the way to move this forward.

@edgarrmondragon
Copy link
Author

From the linked documentation in #460, it doesn't seem like much additional work, but as I said there I won't have time to work on it soon. So if you can get it in here, that's the way to move this forward.

Gotcha, thanks for replying! I'll try to get the free-threaded stuff in this PR and ping you back when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants