Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlize: "@a@b" isn't a valid e-mail, don't mailto:ise it #1870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nabijaczleweli
Copy link

@nabijaczleweli nabijaczleweli commented Jul 20, 2023

This chases https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3Clelaromu5mjgibe6jywrc2iwoikon2piwo2h34rcsyjhbyge5y%40fdtowru7pv5e%3E and thus https://101010.pl/@[email protected]/110742090990556162

It's a common way to spell both "a user of some site" but also universal in the mastodon world. None of these are valid e-mail addresses (especially since urlize makes @[email protected] into <a href="mailto:@[email protected]">@[email protected]</a> which straight-up just isn't really a valid e-mail address anyway).

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code. – I don't think this is needed, since @a@b isn't really a valid email anyway and it was erroneously accepted
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs. – Likewise
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

This chases
  https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3Clelaromu5mjgibe6jywrc2iwoikon2piwo2h34rcsyjhbyge5y%40fdtowru7pv5e%3E
and thus
  https://101010.pl/@[email protected]/110742090990556162

It's a common way to spell both "a user of some site" but also universal
in the mastodon world. None of these are valid e-mail addresses
(especially since urlize makes @eater@cijber.social into
  <a href="mailto:@eater@cijber.social">@eater@cijber.social</a>
which straight-up just isn't really a valid e-mail address anyway).
@nabijaczleweli
Copy link
Author

Four-month bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant