Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output spurious lines if the truncated help text is actually empty #2369

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Don't output spurious lines if the truncated help text is actually empty #2369

merged 1 commit into from
Jun 30, 2023

Conversation

pocek
Copy link
Contributor

@pocek pocek commented Oct 5, 2022

Regression in 92b30e4 (8.1.0). This change brings back the original logic along with the comment.

Improve the tests to catch further regressions.

Fixes #2368

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pocek pocek mentioned this pull request Oct 5, 2022
Closed
6 tasks
@davidism davidism added this to the 8.1.4 milestone Jun 30, 2023
@davidism davidism changed the base branch from main to 8.1.x June 30, 2023 16:39
@davidism davidism merged commit 850bffe into pallets:8.1.x Jun 30, 2023
@pocek pocek deleted the fix-help-truncation branch June 30, 2023 20:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.4
Development

Successfully merging this pull request may close these issues.

Spurious empty lines in the help output (regression)
2 participants
@pocek @davidism