Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush when calling clear, use colorama on Windows #2286

Merged
merged 1 commit into from
Jun 30, 2023
Merged

flush when calling clear, use colorama on Windows #2286

merged 1 commit into from
Jun 30, 2023

Conversation

belliriccardo
Copy link
Contributor

@belliriccardo belliriccardo mentioned this pull request May 13, 2022
Closed
@belliriccardo belliriccardo changed the title Simple fix, see #2284 Small improvement to click.clear(), see #2284 May 13, 2022
@davidism davidism changed the title Small improvement to click.clear(), see #2284 flush when calling clear, use colorama on Windows May 13, 2022
saroad2
saroad2 previously requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@saroad2 saroad2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @belliriccardo , thanks for the PR and sorry for the long delay!

I had a single comment on the PR. Once you address this comment, this PR could be merged.

src/click/termui.py Show resolved Hide resolved
@belliriccardo
Copy link
Contributor Author

belliriccardo commented May 9, 2023 •
edited
Loading

Hi! It's been a while but I havent forgotten :) I added a short comment/explanation, hope the change is ok!

@belliriccardo belliriccardo requested a review from saroad2 May 9, 2023 19:36
@saroad2
Copy link
Collaborator

saroad2 commented May 9, 2023

Hey @belliriccardo , thanks for the clarification! Now it is much clearer.

I'm sorry for the long delay. I'm now walking over older PRs and reviewing them, helping out the pallet team.

One more thing regarding this PR that I forgot to ask: would you mind to add a test or two for the new behavior?

@davidism davidism added this to the 8.1.4 milestone Jun 30, 2023
@davidism davidism changed the base branch from main to 8.1.x June 30, 2023 15:19
@davidism davidism removed the request for review from saroad2 June 30, 2023 15:19
@davidism davidism merged commit 6e70405 into pallets:8.1.x Jun 30, 2023
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saroad2 saroad2 saroad2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.4
Development

Successfully merging this pull request may close these issues.

clear doesn't take effect immediately on Linux
3 participants
@belliriccardo @saroad2 @davidism