--emit-lua: Don't "math.ln=math.log" at the start of every file #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It cluttered the start of *every* file, for something that was a corner case. I've replaced it with a simple gsub for math.ln-->math.log. It's not perfect, but should be good enough until we can get rid of math.ln.
|
Wait a second... I need to edit the input before I compile it, otherwise the indexing math will be off. |
|
Properly implemented in #631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It cluttered the start of every file, for something that was a corner case. I've replaced it with a simple gsub for math.ln-->math.log. It's not perfect, but should be good enough until we can get rid of math.ln.