Merge pull request #634 from pallene-lang/fix-skip-frames

Make traceback tests independent of numbers
pallene-lang · Sep 23, 2024 · 56c41f9 · 56c41f9
2 parents 621c35a + a1547ab
commit 56c41f9
Showing 1 changed file with 60 additions and 56 deletions.
diff --git a/spec/traceback_spec.lua b/spec/traceback_spec.lua
@@ -21,67 +21,71 @@ local function assert_test(test, expected_traceback)
     local luafile = util.shell_quote("spec/traceback/"..test.."/main.lua")
     local ok, _, output_content, err_content = util.outputs_of_execute("pt-lua "..luafile)
     assert(not ok, output_content)
-    assert.are.same(expected_traceback, err_content)
+
+    -- Change error contents replacing numbers which most-likely to change
+    err_content = err_content:gsub("%d+:", "N:"):
+        gsub("%(Skipped %d+ frames%)", "(Skipped N frames)")
+    assert.are.same(expected_traceback, err_content:gsub(":%d+:", ":N:"))
 end
 
 it("Rectangle", function()
     assert_test("rect", [[
-pt-lua: spec/traceback/rect/main.lua:8: file spec/traceback/rect/rect.pln: line 10: wrong type for downcasted value, expected float but found string
+pt-lua: spec/traceback/rect/main.lua:N: file spec/traceback/rect/rect.pln: line N: wrong type for downcasted value, expected float but found string
 stack traceback:
-    spec/traceback/rect/rect.pln:10: in function 'universal_calc_area'
-    spec/traceback/rect/rect.pln:13: in function 'area'
-    spec/traceback/rect/main.lua:8: in <main>
+    spec/traceback/rect/rect.pln:N: in function 'universal_calc_area'
+    spec/traceback/rect/rect.pln:N: in function 'area'
+    spec/traceback/rect/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)
 
 it("Multi-module Lua", function()
     assert_test("module_lua", [[
-pt-lua: spec/traceback/module_lua/main.lua:25: Any normal error from Lua!
+pt-lua: spec/traceback/module_lua/main.lua:N: Any normal error from Lua!
 stack traceback:
     C: in function 'error'
-    spec/traceback/module_lua/main.lua:25: in function 'lua_3'
-    spec/traceback/module_lua/module_lua.pln:12: in function 'pallene_2'
-    spec/traceback/module_lua/main.lua:18: in function 'lua_2'
-    spec/traceback/module_lua/module_lua.pln:8: in function 'pallene_1'
-    spec/traceback/module_lua/main.lua:12: in function 'callback'
-    ./spec/traceback/module_lua/another_module.lua:7: in function 'call_lua_callback'
-    spec/traceback/module_lua/main.lua:28: in <main>
+    spec/traceback/module_lua/main.lua:N: in function 'lua_3'
+    spec/traceback/module_lua/module_lua.pln:N: in function 'pallene_2'
+    spec/traceback/module_lua/main.lua:N: in function 'lua_2'
+    spec/traceback/module_lua/module_lua.pln:N: in function 'pallene_1'
+    spec/traceback/module_lua/main.lua:N: in function 'callback'
+    ./spec/traceback/module_lua/another_module.lua:N: in function 'call_lua_callback'
+    spec/traceback/module_lua/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)
 
 it("Multi-module Pallene", function()
     assert_test("module_pallene", [[
-pt-lua: spec/traceback/module_pallene/main.lua:11: There's an error in everyday life. Alas!
+pt-lua: spec/traceback/module_pallene/main.lua:N: There's an error in everyday life. Alas!
 stack traceback:
     C: in function 'error'
-    spec/traceback/module_pallene/main.lua:11: in function 'lua_2'
-    spec/traceback/module_pallene/module_pallene_alt.pln:8: in function 'alternate_everyday_fn'
-    spec/traceback/module_pallene/main.lua:16: in function 'lua_1'
-    spec/traceback/module_pallene/module_pallene.pln:8: in function 'normal_everyday_fn'
-    spec/traceback/module_pallene/main.lua:19: in <main>
+    spec/traceback/module_pallene/main.lua:N: in function 'lua_2'
+    spec/traceback/module_pallene/module_pallene_alt.pln:N: in function 'alternate_everyday_fn'
+    spec/traceback/module_pallene/main.lua:N: in function 'lua_1'
+    spec/traceback/module_pallene/module_pallene.pln:N: in function 'normal_everyday_fn'
+    spec/traceback/module_pallene/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)
 
 it("Depth recursion", function()
     assert_test("depth_recursion", [[
-pt-lua: spec/traceback/depth_recursion/main.lua:11: Depth reached 0!
+pt-lua: spec/traceback/depth_recursion/main.lua:N: Depth reached 0!
 stack traceback:
     C: in function 'error'
-    spec/traceback/depth_recursion/main.lua:11: in function 'lua_fn'
-    spec/traceback/depth_recursion/depth_recursion.pln:8: in function 'pallene_fn'
-    spec/traceback/depth_recursion/main.lua:14: in function 'lua_fn'
-    spec/traceback/depth_recursion/depth_recursion.pln:8: in function 'pallene_fn'
-    spec/traceback/depth_recursion/main.lua:14: in function 'lua_fn'
-    spec/traceback/depth_recursion/depth_recursion.pln:8: in function 'pallene_fn'
-    spec/traceback/depth_recursion/main.lua:14: in function 'lua_fn'
-    spec/traceback/depth_recursion/depth_recursion.pln:8: in function 'pallene_fn'
-    spec/traceback/depth_recursion/main.lua:14: in function 'lua_fn'
-    spec/traceback/depth_recursion/depth_recursion.pln:8: in function 'pallene_fn'
-    spec/traceback/depth_recursion/main.lua:14: in function 'lua_fn'
-    spec/traceback/depth_recursion/main.lua:17: in <main>
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/depth_recursion.pln:N: in function 'pallene_fn'
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/depth_recursion.pln:N: in function 'pallene_fn'
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/depth_recursion.pln:N: in function 'pallene_fn'
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/depth_recursion.pln:N: in function 'pallene_fn'
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/depth_recursion.pln:N: in function 'pallene_fn'
+    spec/traceback/depth_recursion/main.lua:N: in function 'lua_fn'
+    spec/traceback/depth_recursion/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)
@@ -90,40 +94,40 @@ it("Stack overflow", function()
     assert_test("stack_overflow", [[
 pt-lua: C stack overflow
 stack traceback:
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
 
-    ... (Skipped 379 frames) ...
+    ... (Skipped N frames) ...
 
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/stack_overflow.pln:8: in function 'no_overflow'
-    spec/traceback/stack_overflow/main.lua:10: in function 'please_dont_overflow'
-    spec/traceback/stack_overflow/main.lua:13: in <main>
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/stack_overflow.pln:N: in function 'no_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in function 'please_dont_overflow'
+    spec/traceback/stack_overflow/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)
 
 it("Anonymous lua functions", function()
     assert_test("anon_lua", [[
-pt-lua: spec/traceback/anon_lua/main.lua:9: Error from an anonymous Lua fn!
+pt-lua: spec/traceback/anon_lua/main.lua:N: Error from an anonymous Lua fn!
 stack traceback:
     C: in function 'error'
-    spec/traceback/anon_lua/main.lua:9: in function '<?>'
-    spec/traceback/anon_lua/anon_lua.pln:8: in function 'call_anon_lua_fn'
-    spec/traceback/anon_lua/main.lua:8: in <main>
+    spec/traceback/anon_lua/main.lua:N: in function '<?>'
+    spec/traceback/anon_lua/anon_lua.pln:N: in function 'call_anon_lua_fn'
+    spec/traceback/anon_lua/main.lua:N: in <main>
     C: in function '<?>'
 ]])
 end)