Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

report name of file when reading fails due to e.g. broken header #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blizzara
Copy link

@Blizzara Blizzara commented Dec 1, 2020

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@Blizzara
Copy link
Author

Blizzara commented Dec 1, 2020

The CI failure is dependency resolution, which was failing for me locally as well... Unrelated to the code diff though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant