Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add record support #17

Closed
wants to merge 20 commits into from
Closed

Add record support #17

wants to merge 20 commits into from

Conversation

xanderbailey
Copy link
Contributor

Before this PR

Previously java poet didn't support generating record types and now it does!

After this PR

==COMMIT_MSG==
Add record support
==COMMIT_MSG==

Possible downsides?

@palantirtech
Copy link
Member

Thanks for your interest in palantir/javapoet, @xanderbailey! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@xanderbailey xanderbailey requested a review from pkoenig10 May 1, 2024 12:46
pkoenig10
pkoenig10 reviewed May 1, 2024
View reviewed changes
javapoet/src/test/java/com/palantir/javapoet/JavaFileTest.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/MethodSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/MethodSpec.java Outdated Show resolved Hide resolved
@xanderbailey xanderbailey requested a review from pkoenig10 May 1, 2024 18:05
pkoenig10
pkoenig10 reviewed May 9, 2024
View reviewed changes
Copy link
Member

@pkoenig10 pkoenig10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a handful of comments

javapoet/src/main/java/com/palantir/javapoet/MethodSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/MethodSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
@pkoenig10
Copy link
Member

Would also like @carterkozak to take a brief look, just to get another opinion on this API.

@carterkozak
Copy link
Contributor

@pkoenig10 sorry, I haven't had a chance to give this a thorough review yet. If you're happy with it, I trust your judgement

@xanderbailey xanderbailey requested a review from pkoenig10 June 2, 2024 17:33
pkoenig10
pkoenig10 reviewed Jun 3, 2024
View reviewed changes
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/test/java/com/palantir/javapoet/JavaFileTest.java Outdated Show resolved Hide resolved
javapoet/src/test/java/com/palantir/javapoet/JavaFileTest.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
javapoet/src/main/java/com/palantir/javapoet/TypeSpec.java Outdated Show resolved Hide resolved
@xanderbailey xanderbailey requested a review from pkoenig10 June 20, 2024 20:47
@policy-bot policy-bot bot dismissed pkoenig10’s stale review July 23, 2024 21:03

Invalidated by push of 9f0f4d4

pkoenig10
pkoenig10 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@pkoenig10 pkoenig10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@changelog-app
Copy link

changelog-app bot commented Jul 24, 2024 •
edited by pkoenig10
Loading

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add support for records.

Check the box to generate changelog(s)

  • Generate changelog entry

@xanderbailey xanderbailey mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak left review comments

@pkoenig10 pkoenig10 pkoenig10 approved these changes

Assignees
No one assigned
Labels
autorelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xanderbailey @palantirtech @pkoenig10 @carterkozak @xbailey