Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aruco 3.0.4 #44

Open
wants to merge 25 commits into
base: kinetic-devel
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix shadowed variables
Victor Lopez committed Sep 27, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a0bee04f990a7996f389b4f0863861df5f27aa89
10 changes: 5 additions & 5 deletions aruco/include/aruco/levmarq.h
Original file line number Diff line number Diff line change
@@ -166,7 +166,7 @@ class LevMarq
//--------
eVector curr_z, x64;
double currErr, prevErr, minErr;
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> I, J;
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> I, _J;
double mu, v;
std::function<void(const eVector &)> _step_callback;
std::function<bool(const eVector &)> _stopFunction;
@@ -261,7 +261,7 @@ void LevMarq<T>::init(eVector &z, F_z_x f_z_x)
I.setIdentity();
f_z_x(curr_z, x64);
minErr = currErr = prevErr = x64.cwiseProduct(x64).sum();
J.resize(x64.rows(), z.rows());
_J.resize(x64.rows(), z.rows());
mu = -1;
}

@@ -270,9 +270,9 @@ void LevMarq<T>::init(eVector &z, F_z_x f_z_x)
template<typename T>
bool LevMarq<T>::step(F_z_x f_z_x, F_z_J f_J)
{
f_J(curr_z, J);
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> Jt = J.transpose();
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> JtJ = (Jt * J);
f_J(curr_z, _J);
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> Jt = _J.transpose();
Eigen::Matrix<T, Eigen::Dynamic, Eigen::Dynamic> JtJ = (Jt * _J);

eVector B = -Jt * x64;
if (mu < 0)
8 changes: 4 additions & 4 deletions aruco/src/aruco/markerdetector.cpp
Original file line number Diff line number Diff line change
@@ -184,22 +184,22 @@ int MarkerDetector::getMarkerWarpSize()
return _params._markerWarpPixSize * ndiv; // this is the minimum size that the smallest marker will have
}

void MarkerDetector::buildPyramid(std::vector<cv::Mat> &ImagePyramid, const cv::Mat &grey, int minSize)
void MarkerDetector::buildPyramid(std::vector<cv::Mat> &ImagePyramid, const cv::Mat &grey_img, int minSize)
{
// determine number of pyramid images
int npyrimg = 1;
cv::Size imgpsize = grey.size();
cv::Size imgpsize = grey_img.size();
while (imgpsize.width > minSize)
{
imgpsize = cv::Size(imgpsize.width / _params.pyrfactor, imgpsize.height / _params.pyrfactor);
npyrimg++;
}

ImagePyramid.resize(npyrimg);
imagePyramid[0] = grey;
imagePyramid[0] = grey_img;

// now, create pyramid images
imgpsize = grey.size();
imgpsize = grey_img.size();
for (int i = 1; i < npyrimg; i++)
{
cv::Size nsize(ImagePyramid[i - 1].cols / _params.pyrfactor, ImagePyramid[i - 1].rows / _params.pyrfactor);
4 changes: 2 additions & 2 deletions aruco/src/aruco/markerlabelers/dictionary_based.cpp
Original file line number Diff line number Diff line change
@@ -52,8 +52,8 @@ void DictionaryBased::setParams(const Dictionary& dic, float max_correction_rate
else
vdic.push_back(dic);

for (auto &dic : vdic)
nbits_dict[dic.nbits()].push_back(&dic);
for (auto &dic2 : vdic)
nbits_dict[dic2.nbits()].push_back(&dic2);

_max_correction_rate = std::max(0.f, std::min(1.0f, max_correction_rate));
}