Fix/swift6 strict sendable concurrency#21
Merged
Conversation
Replace open-class inheritance with final-class composition across AbstractAgent, HttpAgent, AgUiAgent, and StatefulAgUiAgent. Extract AgentTransport protocol (Sendable) and HttpAgentTransport struct so all stored properties are `let` + Sendable — no @unchecked needed. Also fix five concurrency correctness gaps (Phases 1-5): - Convert @unchecked Sendable helper classes to structs (ToolCallBuilder, MutableToolExecutionStats, HttpAgentConfig headers mutation) - Remove didSet from config types to satisfy Swift 6 Sendable rules - Rewrite TimeBatchedAsyncSequence with producer-consumer actor pattern to eliminate element loss at window boundaries - Add continuation.onTermination task cancellation to all bare Task {} sites inside AsyncThrowingStream continuations - Back LastEventIdBox with NSLock for genuine thread safety Tests: 1229 passed, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Type of Change
feat- New featurefix- Bug fixrefactor- Code refactoringdocs- Documentation updatetest- Test additions/updateschore- Build/tooling changesTesting
swift test)Code Quality
swift package plugin swiftformat)swiftlint lint)Screenshots
Related Issues
Closes #
Relates to #
Breaking Changes
Breaking changes:
Additional Context
Reviewer Checklist