Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ogr just for stable releases #897

Conversation

majamassarini
Copy link
Member

in copr packit-stable project

.packit.yaml Outdated
@@ -77,7 +77,6 @@ jobs:
targets:
- fedora-stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fedora-stable still includes F40 that fails

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not sure what we want to do here… we could probably omit targets altogether and deduce from the Copr settings, but that would mean that we need to remove this entry from all of specfile, ogr, packit, cause either of them could “reset” the F40 and EL9 back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already started removing things in packit, https://github.com/packit/packit/pull/2549/files. At least we should remove epel9 there. And use fedora-latest instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we intend to move our deployments with Fedora releases, then I guess we could use fedora-latest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we intend to move our deployments with Fedora releases, then I guess we could use fedora-latest

Hm, but if we forget will we be able to notice (soon enough) that the images contain some old builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're talking about packit/packit-stable Copr, I would say it would be enough to deduce the targets from Copr and adjust the release in images and Copr repo at the same time, manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also means we should eradicate targets: […] in all repos that build in packit/packit-stable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I follow, why using fedora-latest our images could use old builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I follow, why using fedora-latest our images could use old builds?

If we bump (or not bump) the base image without adjusting the Copr settings (or config here), we will start pulling the dependencies from official Fedora repository (which will not necessarily be the same as us moving the stable and using Copr repo)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about going with fedora-latest-stable?

@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from 4427b7c to c47b4f1 Compare March 10, 2025 14:24
Copy link
Contributor

@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from c47b4f1 to 20fc293 Compare March 10, 2025 14:42
Copy link
Contributor

@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from 20fc293 to 072a51e Compare March 10, 2025 15:53
Copy link
Contributor

@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from 072a51e to e8ecfcb Compare March 11, 2025 08:26
Copy link
Contributor

.packit.yaml Outdated
@@ -108,4 +107,4 @@ jobs:
- packit
dist_git_branches:
- fedora-all
- epel-9
- epel-10-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to coordinate this with specfile and packit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have already changed the packit .packit.yaml file but I didn't push it, if this is what you mean. I was waiting to see the build succeed in ogr... but I don't see any build/test for epel10 here, after my push. Are we still taking the config from the head of a PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no builds because the epel-10-all alias doesn't work yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will wait tomorrow, that fedora-distro-aliases should reach stable update, to test this PR properly and also push the packit one.

.packit.yaml Outdated
@@ -96,7 +95,7 @@ jobs:
trigger: release
dist_git_branches:
- fedora-all
- epel-9
- epel-10-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather do this (same for propose_downstream):

Suggested change
- epel-10-all
epel-10:
fast_forward_merge_into:
- epel-10-branched

Copy link
Member

@nforro nforro Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we are not doing it for Fedora on purpose, then I suppose it makes sense to have divergent branches in EPEL 10 too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought that we could start with the same commits, until we can at least. And than when we are forced we can diverge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, without fast_forward_merge_into, the epel10.0 branch will have different commit hashes than epel10.

@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from e8ecfcb to 1af3e1c Compare March 12, 2025 12:38
Copy link
Contributor

epel9 is no more supported due to pyforgejo.
Build in packit-stable copr project the package only for the latest stable Fedora.
@majamassarini majamassarini force-pushed the copr_builds_just_in_stable branch from 1af3e1c to ec67494 Compare March 13, 2025 09:22
Copy link
Contributor

@majamassarini
Copy link
Member Author

In the end we decided to remove both epel9 and epel10, since there are missing dependencies (gitlab bugzilla and pygithub bugzilla).

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Mar 13, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/73e71f887d2f4089a11f82dd73862d7f

✔️ pre-commit SUCCESS in 2m 51s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e0498a6 into packit:main Mar 13, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants