chore: delete the two orphaned crate husks left by the ACP port - #201
Open
Ukaykhingmarma28 wants to merge 2 commits into
Open
chore: delete the two orphaned crate husks left by the ACP port#201Ukaykhingmarma28 wants to merge 2 commits into
Ukaykhingmarma28 wants to merge 2 commits into
Conversation
The Zed ACP port replaced the old stack, and `crates/atlas-agents` lost its
manifest and its `src/` along with it. What survived was a single tracked
example, `backend_suite.rs`, that opens with `use atlas_agents::{...}` — a
crate that no longer exists — inside a directory with no Cargo.toml. It could
not compile, and nothing depended on it.
`package.json`'s `acp:test` script was its only caller, and it has been dead
for exactly as long:
$ cargo run --manifest-path crates/atlas-agents/Cargo.toml --example backend_suite
error: manifest path `crates/atlas-agents/Cargo.toml` does not exist
Removing the example without the script would leave the dangling half behind,
so both go. Nothing else in the tree, and no CI job, references either.
Same shape as the atlas-agents husk in the previous commit, missed on the
first pass because the search was scoped to `atlas-agents`.
`crates/atlas-registry` has no Cargo.toml either. All that is left is
`examples/registry_e2e.rs`, which opens with
use atlas_acp::{AcpEvent, AgentId, AgentRegistry, EventSink, SpecSource};
use atlas_registry::RegistryStore;
— two crates the port deleted. `src-tauri/Cargo.toml` says as much in a
comment: "`atlas-acp`, `atlas-registry` and `atlas-agentkit` are deleted."
The directory outlived the statement.
Nothing references the example: no dependency, no npm script, no CI job.
Ukaykhingmarma28
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up sweep after the Zed ACP port (#198). Deletions only — no behaviour changes.
What's dead
The port replaced the old agent stack and deleted
atlas-acp,atlas-agentkit, and the oldatlas-agents/atlas-registryinternals. Two crate directories outlived that deletion. Neither has aCargo.toml— each is just a strayexamples/file importing crates that no longer exist, so neither can compile and nothing depends on either.crates/atlas-agents/examples/backend_suite.rs— opens withuse atlas_agents::{...}. Its only caller waspackage.json'sacp:test, dead for exactly as long. Onmaintoday:Removing the example without the script would leave the dangling half behind, so both go.
crates/atlas-registry/examples/registry_e2e.rs— opens withuse atlas_acp::{...}anduse atlas_registry::RegistryStore.src-tauri/Cargo.toml:59already states the situation in a comment: "atlas-acp,atlas-registryandatlas-agentkitare deleted." The directory outlived the statement. Nothing references this one at all — no dependency, no script, no CI job.Checks
atlas-agents,atlas_agents,atlas-registry,atlas_registry,backend_suite, orregistry_e2eas code. Remaining hits are prose inARCHITECTURE.md(see below).acp:test.package.jsonremains valid JSON; 19 scripts left.bun run test— 43 files, 805 tests, all passing.typecheck(both tsconfigs) passed on each commit.Separate follow-up, already in progress
ARCHITECTURE.mdstill documents the pre-port stack in detail —AgentBackendatcrates/atlas-agents/src/backend.rs,AgentManagerat.../src/manager.rs,SessionActorat.../src/actor.rs, plus the crate table and the directory tree.crates/atlas-cersei/ARCHITECTURE.mdhas the same problem. Those paths were already stale before this PR, and rewriting the architecture docs is a bigger job than a dead-code sweep should smuggle in. That is coming as its own PR.