Remove orphaned artifacts_sessions command - #193
Open
LazarusQue wants to merge 1 commit into
Open
Conversation
Lost its only frontend caller when a memory view was removed; no TS caller remains and the IPC contract test doesn't guard it. Shared helpers (open_reader, workspace_id_for, session_summaries) stay since other commands still use them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
artifacts_sessions(src-tauri/src/commands/capture.rs) lost its only frontend caller when a memory view was removed and has been dead surface since; removed the fn and itsgenerate_handler!registration inlib.rs.open_reader,workspace_id_for,session_summaries) are still used by other commands incapture.rs, so those are untouched.Closes #173
Test plan
cargo checkinsrc-tauriis warning-freebun run testpasses (609 tests, includes IPC contract test)bunx tsc --noEmitpassesbun run lintpasses