Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
QSparks
force-pushed
the
py-sprint-25q1
branch
3 times, most recently
from
f736547 to
4a37e41
Compare
corviday
left a comment
corviday
left a comment
There was a problem hiding this comment.
Looks good to me.
I especially like all the poe scripts and the documentation of them, a lot of thought went into that.
| # Development | ||
|
|
||
| This `docker-compose` is set up for development purposes. It will up a dev instance of `quail` with production settings. All you are required to do is to add the following lines to `birdhouse-config/env.local` running on `dev03`: | ||
| This `docker-compose` is set up for development purposes. It will up a dev instance of `quail` with production settings. All you are required to do is to add the following lines to `birdhouse-config/env.local` running on `marble-dev01`: |
| - Push it: `git push` | ||
| - Push tag: `git push --tags` | ||
|
|
||
| See the [bumpversion](https://pypi.org/project/bumpversion/) documentation for details. |
| prepare-notebooks Download the output sanitizer config for notebook tests | ||
| test-notebooks Run all local notebook tests with sanitized output | ||
| test-notebooks-local Run notebook tests locally using nbval with sanitization | ||
| docs Convert notebooks to HTML for documentation |
There was a problem hiding this comment.
Lots of tasks, good documentation of them. 👍
| name = "quail" | ||
| version = "0.7.1" | ||
| description = "A Web Processing Service for Climate Data Analysis." | ||
| authors = [{ name = "Nikola Rados", email = "nrados@uvic.ca" }] |
| env = { LOCAL_URL = "http://localhost:5000" } | ||
| help = "Run notebook tests locally using nbval with sanitization" | ||
|
|
||
| # [tool.poe.tasks.test-notebooks-prod] |
There was a problem hiding this comment.
I left them commented out because local manual runs are more practical for development. Redeploying to Marble is tedious and nbval sometimes shows failures that pass fine in JupyterLab.
| "output_type": "stream", | ||
| "text": [ | ||
| "Using quail on https://docker-dev03.pcic.uvic.ca/twitcher/ows/proxy/quail/wps\n" | ||
| "Using quail on https://marble-dev01.pcic.uvic.ca/twitcher/ows/proxy/quail/wps\n" |
There was a problem hiding this comment.
Probably a question for another PR, but should this be configured dynamically?
There was a problem hiding this comment.
This essentially is, when viewed through the notebook preview it is the output text from running:
url = get_target_url("quail")
print(f"Using quail on {url}")
| { | ||
| "cell_type": "code", | ||
| "execution_count": 1, | ||
| "execution_count": 12, |
There was a problem hiding this comment.
I'm just curious what the deal with all the changed execution_counts is?
There was a problem hiding this comment.
This is metadata referring to how many times a cell has executed. This could be relevant for non-linear executing notebooks, but it isn't important here. We could create a pre-commit action to clean up metadata and simplify future reviews. I'll open an issue for that improvement.
2 participants
Pending: